Closed
Conversation
* move stock arrays to test data
Member
|
Wrong merge target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the post-merge issues raised by @dkillick on #2206.
Locking at the iris plot level will not guarantee to the user thread-safe plotting. There is still the possibility of an iris plot using an mpl figure from a different thread in certain circumstances. In the case of #2206, the implementation introduced a locking mechanism at the iris plotting api level, which is in fact at too low a level.
If a user insists on using iris plotting in a threaded context, then we should advocate that they take responsibility for locking themselves (which, to be fair, is pretty simple to do) in combination with creating the target mpl figure/axes.
Note that, for clarity, we do require to maintain non re-entrant locking at the individual graphics test case level to avoid the issues raised in #2195.
Closes #2210.