Prevent dot_path tests from corrupting the stored path.#2220
Closed
pp-mo wants to merge 1 commit intoSciTools:masterfrom
Closed
Prevent dot_path tests from corrupting the stored path.#2220pp-mo wants to merge 1 commit intoSciTools:masterfrom
pp-mo wants to merge 1 commit intoSciTools:masterfrom
Conversation
Member
|
This will need closing now that #2222 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, the tests in
iris.tests.test_file_savethat use "dot" can fail, if they happen to run _after_ this one.Especially true as the last test in "test__dot_path" leaves it set to None.
Background : I think the order of tests running is not fully guaranteed, and may not always be repeatable.
? Possibly it is different for the different ways, i.e. "python setup.py test" // "nosetests" // "python -m unittest" ?