limit filelock use

[marqh]

remove the behaviour, introduced in #2192, where installations without write permissions to the iris source directories are unable to run tests, due to

IOError: [Errno 13] Permission denied: 'imagerepo.lock'

@bjlittle does this maintain your desired behaviour for developers whilst removing the installation and testing block?

[DPeterK]

This looks like an improvement over the initial proposal.

[lbdreyer]

Thanks @marqh :)

[bjlittle]

@marqh @lbdreyer @dkillick You've introduced a bug here ...

The lock file imagerepo.lock is a separate file from the file imagerepo.json that the lock protects access to in the lock critical region.

The code change that @lbdreyer merged uses the imagerepo.json file as the actual lock file in error. That's bad.

Line 737 should be replaced with the following:

lock = filelock.FileLock(os.path.join(_RESULT_PATH, 'imagerepo.lock'))

And line 811 now requires to be deleted ... infact the check_graphic function no longer needs to be a wrapper function to _assert_graphic. It should be the case now that _assert_graphic is check_graphic.

Someone needs to fix this now before v1.11.x is cut

[lbdreyer]

Interesting that the test still pass 😕

Thanks for catching this @bjlittle!

I have now put up PR #2225 that should hopefully fix it.

[bjlittle]

@lbdreyer There are no tests to test the testing framework.

[DPeterK]

There are no tests to test the testing framework

This has always struck me as an abrupt irony.