Fix test runner override and no-data#2242
Merged
DPeterK merged 1 commit intoSciTools:v1.11.xfrom Nov 16, 2016
Merged
Conversation
Member
To be fair, I'd already merged the PR by that point, if, apparently prematurely... |
Member
Author
|
@dkillick Yeah, I came to that party slightly late ... |
DPeterK
reviewed
Nov 16, 2016
| # has been set. This is used in setup.py in the TestRunner command to | ||
| # enable us to simulate the absence of external data. | ||
| override = os.environ.get("override_test_data_repository") | ||
| override = os.environ.get("OVERRIDE_TEST_DATA_REPOSITORY") |
Member
There was a problem hiding this comment.
Does there need to be another change somewhere so that this environment variable is now supplied in all-caps? Or is this just something that a user specifies to the commandline at runtime?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the use of the
override_test_data_repositoryenvironment variable, and applies the standard naming convention of using upper-case environment variables 🙏It also fixes the broken test runner option
--no-datato actually ignore the test data.This corrects #2211 and addresses the ignored comment
@dkillick and @lbdreyer