Document pseudo-level support in structured um loading.#2292
Merged
marqh merged 2 commits intoSciTools:v1.12.xfrom Jan 10, 2017
Merged
Document pseudo-level support in structured um loading.#2292marqh merged 2 commits intoSciTools:v1.12.xfrom
marqh merged 2 commits intoSciTools:v1.12.xfrom
Conversation
Merged
Member
Author
|
Problems still to fix. |
pp-mo
force-pushed
the
struct_load_docsfix
branch
from
f5a930d to
c63114e
Compare
Member
Author
|
... fixed Can you check it out @marqh ? |
marqh
reviewed
Jan 10, 2017
|
|
||
| At present, fields with different values of 'LBUSER5' | ||
| (pseudo-level) are *also* treated as different phenomena. | ||
| This is a temporary fix, standing in place for a more correct |
Member
There was a problem hiding this comment.
i don't think i would use the term 'temproary fix'
I would prefer to state what the behaviour is and how it will be experienced.
perhaps
This will result in separate cubes for differnet values of LBUSER, with a coordinate representing the value. These can be concatenated/merged to form cubes with a pseudo level dimension.
or somesuch
pp-mo
force-pushed
the
struct_load_docsfix
branch
from
611be1e to
b8d51ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just explains the temporary solution introduced in #2274