WIP: Removed the deprecated iris.fileformats.grib.#2617
Closed
pelson wants to merge 2 commits intoSciTools:masterfrom
Closed
WIP: Removed the deprecated iris.fileformats.grib.#2617pelson wants to merge 2 commits intoSciTools:masterfrom
pelson wants to merge 2 commits intoSciTools:masterfrom
Conversation
Member
Author
|
I haven't touched lib/iris/tests/integration/format_interop/test_name_grib.py - we need to do some more work to remove the full integration testing from iris-core. |
Member
Author
|
Some of the docs talk about |
Member
Author
|
Lots of tests timing out (as per #2618). One peculiar failure that I'm not able to reproduce locally: |
Member
Author
|
FWIW: SciTools/iris-grib#82 ports the iris.fileformats.grib functionality to iris_grib. |
Merged
pp-mo
added a commit
to pp-mo/iris
that referenced
this pull request
Oct 25, 2017
Member
Author
|
Merged in #2810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mostly worked off of e45acf7#diff-319dea6a401e00cbfd00d1aa0969c6a4 to figure out what was still using iris.fileformats.grib.
I've not touched
tools/translatorandtools/gen_translations.pyas I'm not certain how much of that has moved over to iris_grib.