Remove rule logging and related code#2786
Conversation
| @@ -148,13 +134,6 @@ def get_dir_option(section, option, default=None): | |||
| # Logging options | |||
| _LOGGING_SECTION = 'Logging' | |||
|
|
|||
There was a problem hiding this comment.
@LukeC92 @dkillick @pelson @pp-mo @djkirkham
I know that this entire set of logging options is not deprecated, but while we are working towards Iris 2.0 and have also just implemented Python logging (with a view to further development), I really think we should take a long hard look at whether we still need this and should absolutely remove it if we don't.
There was a problem hiding this comment.
Yep. import_logger can be removed long-term.
Definitely a separate PR, but I'd probably support it happening for 2.0 without a deprecation warning. We will have to document the breaking change though (and think about the impact for people who have a logging section in their config - would it now break if we removed it, or just be ignored silently?).
All questions to be answered outside of this PR.
There was a problem hiding this comment.
@LukeC92 Generally I am happy with these changes, and so are the tests, which is good. I would like a conversation with some members of the team about the remaining logging options, but if we follow all the rules that will not affect this PR, so I am happy to approve it.
Good job Luke.
|
My favourite kind of PR - one that makes the codebase smaller & tidier. |
|
I've started writing up the "What's New" for this pull request but I am not sure what the best way is to represent all of these changes. |
5 participants
This is a continuation of @dkillick 's Pull Request #2697 . As well as removing rule logging config items and all rule logging functionality from
fileformats/rules.pyI also removedtest_verbose_fileformat_rules_logging.pywhich now seems redundant, and a referece to rule logs inpp.save_pairs_from_cube.Closes #2655