Rename pp_rules to pp_load_rules#2790
Merged
corinnebosley merged 6 commits intoSciTools:masterfrom Oct 18, 2017
Merged
Conversation
DPeterK
force-pushed
the
rename_pp_rules
branch
from
e8f1466 to
6bc18cc
Compare
Member
Author
|
Now rebased following recent changes. |
Contributor
|
Does this need a What's New entry? It's technically a public API change. |
DPeterK
force-pushed
the
rename_pp_rules
branch
from
ca626cd to
9ffac41
Compare
corinnebosley
approved these changes
Oct 18, 2017
Member
corinnebosley
left a comment
corinnebosley
left a comment
There was a problem hiding this comment.
There is still a reference or two to irirs.filefoprmats.load_rules.py in the whitepaper. Are we ignoring this for now and updating it at a later time?
If that is the case, then I'm happy to merge.
| @@ -0,0 +1,2 @@ | |||
| `iris.fileformats.pp_rules` has been renamed to `iris.fileformats.pp_load_rules`. | |||
| This has been done for the sake of clarity following the introduction of `iris.fileformats.pp_save_rules`. No newline at end of file | |||
Member
|
! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation to convert PP save rules from a text file to Python, this PR renames
pp_rules(that contains rules for loading PP files) topp_load_rules(more descriptive, less likely to be confusing in the future).