Removed class iris.fileformats.rules.CoordAndDims#2791
Merged
corinnebosley merged 3 commits intoSciTools:masterfrom Oct 17, 2017
Merged
Removed class iris.fileformats.rules.CoordAndDims#2791corinnebosley merged 3 commits intoSciTools:masterfrom
corinnebosley merged 3 commits intoSciTools:masterfrom
Conversation
Contributor
Author
|
This seems to solve issue #2672 and all of the tests pass. However I'd appreciate if somebody could check the changes I've made. For example are the comments I've re-written presented in an acceptable manner. |
This was referenced Oct 13, 2017
Merged
Member
LukeC92
force-pushed
the
remove_coord_dims
branch
from
dda7228 to
2f57f07
Compare
Member
|
Closes #2672 |
Member
|
@LukeC92 Good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address issue #2672 . Wanted to see how this fairs against the Travis tests, further changes may be necessary.