Skip to content

Remove deprecated function analysis.linear#2801

Merged
corinnebosley merged 3 commits intoSciTools:masterfrom
DPeterK:remove_analysis_linear
Oct 17, 2017
Merged

Remove deprecated function analysis.linear#2801
corinnebosley merged 3 commits intoSciTools:masterfrom
DPeterK:remove_analysis_linear

Conversation

@DPeterK
Copy link
Member

@DPeterK DPeterK commented Oct 16, 2017

Closes #2666

@DPeterK DPeterK requested a review from corinnebosley October 16, 2017 14:14
Copy link
Member

@corinnebosley corinnebosley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better.

@DPeterK DPeterK force-pushed the remove_analysis_linear branch 2 times, most recently from 5d98dc0 to 9c13b1a Compare October 16, 2017 16:10
@DPeterK DPeterK force-pushed the remove_analysis_linear branch from aad0e44 to 0174a4e Compare October 17, 2017 09:44
@corinnebosley
Copy link
Member

I was a little concerned that the tests in here were removed rather than modified or replaced, but having had a look and talked to Pete about it, I can see that there are plenty of tests covering the functionality of the replacement method 'Linear'.

So I'm happy with this and going to merge it.

@corinnebosley corinnebosley merged commit 7f4e6a9 into SciTools:master Oct 17, 2017
@DPeterK DPeterK deleted the remove_analysis_linear branch October 17, 2017 10:33
@QuLogic QuLogic added this to the v2.0 milestone Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants