what's-new for removal of analysis interpolation module#2819
what's-new for removal of analysis interpolation module#2819DPeterK merged 3 commits intoSciTools:masterfrom
Conversation
|
@dkillick You want me to pop the word 'deprecated' in there to cover our backs? |
|
@dkillick I did it anyway. |
Sure, why not 😉 |
DPeterK
left a comment
DPeterK
left a comment
There was a problem hiding this comment.
@corinnebosley I think this one needs a little work still...
| @@ -0,0 +1,8 @@ | |||
| * The deprecated module ```iris.analysis.interpolate``` has been removed, along with the following functions: | |||
There was a problem hiding this comment.
Why not add "deprecated" before "functions" as well...
Also, Linear1DExtrapolator was a class and not a function, so you should probably turn the last bit of this sentence into "the following deprecated classes and functions:".
| @@ -0,0 +1,8 @@ | |||
| * The deprecated module ```iris.analysis.interpolate``` has been removed, along with the following functions: | |||
| * ```iris.analysis.linear``` | |||
| * ```iris.analysis.all_points_in_range``` | |||
There was a problem hiding this comment.
This is a method in Linear1DExtrapolator, which technically was never deprecated (outside of being part of the deprecated class), so it should not be in this list.
| * ```iris.analysis.regrid``` | ||
| * ```iris.analysis.extract_nearest_neighbour``` | ||
| * ```iris.analysis.nearest_neighbour_indices``` | ||
| * ```iris.analysis.Linear1dExtrapolator``` |
There was a problem hiding this comment.
You're missing iris.analysis.interpolate.regrid_to_max_resolution from this list.
Also, you need to add "interpolate" to each item in the list...
|
@dkillick I added the [ci skip] which worked its lovely magic, so you will have to check the changes you requested. |
3 participants
No description provided.