Merged
Conversation
|
Could not review pull request. It may be too large, or contain no reviewable changes. |
|
Could not review pull request. It may be too large, or contain no reviewable changes. |
Member
|
@pp-mo - I'm somewhat concerned about this one. What happened with it? It says "merged", but there are 0 commits. It also says "Do not merge", yet it looks like it might have been merged. Any clues? 😄 |
Member
Author
Not entirely sure of details, but I suspect that #2967 included the original commit for this, so it became redundant when that was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE COMMENT, BUT DO NOT MERGE
because, apart from discussion, a test is still needed ...
Purpose:
User code often forms multiple stats, where data may be very large.
= several small, lazy, calculated results derived from same large, lazy data
Calculation scans the data, each time you realise one.
This can + should be done in parallel with
da.compute(*dask_stats_arrays).We need to assign back into Iris cube.data elements.
I can't find a neat Python idiom for this, so we can provide a simple utility routine.
Note: I'm proposing to put this in package
irisitself, as I don't rate the alternatives :iris._lazy_datais privateiris.utils, on inspection, I think is for "handy things you might just have written yourself"whereas : this code uses knowledge of internals.