Test imagehash 'old_hex_to_hash' function#2974
Closed
pp-mo wants to merge 4 commits intoSciTools:masterfrom
Closed
Test imagehash 'old_hex_to_hash' function#2974pp-mo wants to merge 4 commits intoSciTools:masterfrom
pp-mo wants to merge 4 commits intoSciTools:masterfrom
Conversation
pp-mo
force-pushed
the
unpin_imagehash_use_oldfn
branch
from
b4b5f6b to
c7d76f5
Compare
pp-mo
changed the title
pp-mo
force-pushed
the
unpin_imagehash_use_oldfn
branch
from
c7d76f5 to
81c88fb
Compare
This was referenced Mar 13, 2018
Closed
Member
|
Looks like this is being obsoleted by #2989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Like #2973 this is just fishing for information.
( We can't simply apply the 'old' hash function to everything, because then we can't add any new hashes.
So, we will need to either convert all existing hash keys, or use old+new methods selectively somehow. )