Merged
Conversation
pp-mo
force-pushed
the
temporary_dask_fix
branch
from
117a258 to
c89f43e
Compare
pp-mo
force-pushed
the
temporary_dask_fix
branch
from
5ca1611 to
6e32e14
Compare
Member
Author
Closed
pp-mo
force-pushed
the
temporary_dask_fix
branch
from
159c324 to
d69222a
Compare
This was referenced Aug 13, 2018
Closed
Member
|
I like the simplicity of this fix so I'm going to merge this. |
Member
|
I should have squashed the commits! Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin dask + fix minor dask usage glitch, to get tests passing again ( 🤞 ) .
Changes are basically cherrypicked from #3127
NASTY PROBLEM :
Recent numpy (1.15 ?) uses different formatting for printing arrays in Python 2 + Python 3.
Alternative print solutions make the sample code very messy (as discussed offline with @lbdreyer).
I've fixed this for now by adopting the Python 3 output, and disabling the doctests on Python 2
However that is pretty wasteful, as a whole row of the Travis test matrix now does almost nothing.
I expect there is some way of controlling that, but for now I don't care enough.