Lambert conformal secant latitudes#3231
Merged
corinnebosley merged 3 commits intoSciTools:v2.2.xfrom Nov 28, 2018
Merged
Conversation
Member
Author
|
Closes #3228 |
stickler-ci
reviewed
Nov 27, 2018
lib/iris/tests/test_coordsystem.py
Outdated
| LambertConformal(secant_latitudes=(1, 2, 3)) | ||
|
|
||
| def test_secant_latitudes_single_value(self): | ||
| lat_1 = 40 |
There was a problem hiding this comment.
E101 indentation contains mixed spaces and tabs
W191 indentation contains tabs
lib/iris/tests/test_coordsystem.py
Outdated
| lcc = LambertConformal(secant_latitudes=lat_1) | ||
| ccrs = lcc.as_cartopy_crs() | ||
| self.assertEqual(lat_1, ccrs.proj4_params['lat_1']) | ||
| self.assertNotIn('lat_2', ccrs.proj4_params) |
There was a problem hiding this comment.
E101 indentation contains mixed spaces and tabs
W191 indentation contains tabs
Member
Author
|
@corinnebosley This PR will fail and require to be rebased once #3230 is resolved |
bjlittle
commented
Nov 27, 2018
bjlittle
force-pushed
the
lambert-conformal-secant-latitudes
branch
from
94f10f8 to
be7d02f
Compare
Member
|
@bjlittle Looks good to me. I'm pushing the button. |
Member
Author
|
Awesome, thanks @corinnebosley 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #3228