Get licence header test working again.#3272
Conversation
pp-mo
changed the title
pp-mo
force-pushed
the
reenable_coding_tests
branch
5 times, most recently
from
abe4964 to
64dabf5
Compare
|
Could not review pull request. It may be too large, or contain no reviewable changes. |
pp-mo
force-pushed
the
reenable_coding_tests
branch
from
b28224e to
6359f53
Compare
pp-mo
force-pushed
the
reenable_coding_tests
branch
from
8e0ba3b to
e754797
Compare
pp-mo
force-pushed
the
reenable_coding_tests
branch
from
144cb10 to
bf9ad75
Compare
|
Yay, fixed at last !!! 😀 @lbdreyer this was triggered by your comment on #3259 I think it's probably simplest to agree+merge this one first, Can you check it out ? |
|
Yep, this looks good! Thanks @pp-mo :) |
|
FYI the header rules were significantly relaxed a few weeks ago in https://github.com/SciTools/scitools.org.uk/blob/master/documents/scitools_licensing.md. Essentially the year is entirely superfluous in the header and can be removed entirely. I've avoided doing it wholesale to any of the projects as I don't want to be touching every single file for no reason. The cartopy test has been updated though to support the new guidelines: https://github.com/SciTools/cartopy/pull/1267/files#diff-6545369fccb2d4d7897214fa6787e86d No action needed, just wanted to share the knowledge. 👍 on the change here. |
Thanks, perhaps all devs need to push this.. |
modified. SKIP this commit during the mergeback. * Fix testing cwd for licence header test to work properly. * Remove redundant test runner --coding-tests key. * Update all the missed header years.
modified. SKIP this commit during the mergeback. * Fix testing cwd for licence header test to work properly. * Remove redundant test runner --coding-tests key. * Update all the missed header years.
modified from (#3272). SKIP this commit during the mergeback. * Fix testing cwd for licence header test to work properly. * Remove redundant test runner --coding-tests key. * Update all the missed header years.
…) and modified. SKIP this commit during the mergeback. * Fix testing cwd for licence header test to work properly. * Remove redundant test runner --coding-tests key. * Update all the missed header years.
* Fix testing cwd for licence header test to work properly. * Remove redundant test runner --coding-tests key. * Update all the missed header years.
4 participants
WIP: DO NOT MERGE (yet) !
We seem to have lost this functionality with #3036
Since some time before that point, the run in the 'main' test sequence was giving a "SKIP: Iris installation did not look like a git repo." message (here, for instance)
I think this is because you need to be in the right directory when running the test.