Merged
Conversation
stickler-ci
reviewed
May 15, 2019
lib/iris/tests/unit/experimental/representation/test_CubeListRepresentation.py
Outdated
Show resolved
Hide resolved
Member
Author
Member
Member
|
Ping @DPeterK 😉 |
Member
Author
|
@bjlittle ping noted; unfortunately I'm busy now! I'll see what I can do. |
Member
|
@DPeterK No worries 😉 |
Member
Author
|
@bjlittle I did it 😁 |
Member
Author
|
... shame the tests still didn't pass 😢 Edit: but it looks like it's just a license header thing 🎉 I'll fix... |
This was referenced Aug 23, 2019
Member
Author
|
I've updated the CSS for the cubelist repr, including making use of jupyter variables to define elements of the style. This means the cubelist repr will correctly follow jupyter lab themes. When combined with #3380 the cubelist repr now looks like the following: |
Member
|
@DPeterK Awesome, LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



As a (long-delayed) follow-on to a previous PR to add cube html repr (see #2918), this adds html repr functionality to
CubeListobjects. The html repr is designed to be reasonably simple, retaining the content of the originalCubeListrepr while adding an accordion effect that, when a cube in the list is clicked, expands to reveal the html repr of that cube.