Merged
Conversation
Contributor
Author
|
Alternatively, my new commit adds the new line to the previous cell instead of a new row.
|
|||||||||||||||||||||||||||||||||||||||
DPeterK
requested changes
Aug 23, 2019
Member
DPeterK
left a comment
There was a problem hiding this comment.
@stephenworsley thanks for getting a fix in place for this annoying bug with the cube html repr! Could I ask you to add a test for this new functionality to Test__make_content please, as well as a new test class in the same test module for the new method you've added? Doesn't have to be anything special, just enough to check it's doing what we want (as well as nothing we don't!). Thanks!
pp-mo
reviewed
Sep 4, 2019
Member
Long enough, I think it's good! |
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug with #3351.
Previously, if a cube had an attribute which was a string containing '\n', attempting to get the html_repr of that cube would cause an exception. This pull request would instead add what is in that new line to a new row of the html_repr.
A cube whose string representation looks like:
will now have a html_repr which creates a table looking something like:
This cube and its representations were created with the following code using attributes taken from #3351: