Make PointInCell regridding scheme public (#2732)#3390
Merged
lbdreyer merged 7 commits intoSciTools:masterfrom Sep 9, 2019
Merged
Make PointInCell regridding scheme public (#2732)#3390lbdreyer merged 7 commits intoSciTools:masterfrom
lbdreyer merged 7 commits intoSciTools:masterfrom
Conversation
…emental to analysis. WIP - Still need to fix tests.
lbdreyer
reviewed
Sep 5, 2019
Member
lbdreyer
left a comment
lbdreyer
left a comment
There was a problem hiding this comment.
Great job! Thanks @alastair-gemmell!
I just have a couple of minor comments but otherwise this should be good to go 👍
lib/iris/tests/unit/analysis/regrid/test__CurvilinearRegridder.py
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks @lbdreyer - well spotted points. I've made these changes now and Travis seems happy. |
Member
|
Thanks for the changes @alastair-gemmell! This looks ready to go in :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #2732
Moved the PointInCell regridder and associated code from iris/experimental to the core of Iris (in this case to iris/analysis) in order to make the PointInCell regridding scheme public.
Moved associated tests across from iris/tests/experimental to iris/tests/unit/analysis
Added an exception to raise to users when they attempt to use the PointInCell functionality that has been migrated from experimental to the core of Iris.
Added a whatsnew file to briefly describe the changes