Skip to content

Airspeed Velocity Set Up#3526

Merged
bjlittle merged 14 commits intoSciTools:masterfrom
trexfeathers:asv_setup
Nov 13, 2019
Merged

Airspeed Velocity Set Up#3526
bjlittle merged 14 commits intoSciTools:masterfrom
trexfeathers:asv_setup

Conversation

@trexfeathers
Copy link
Contributor

This pull request enables testing with Airspeed Velocity 🐦

Any user with an ASV install can run the suite of tests held within lib/iris/tests/benchmarking using the shell command asv run, while in the root directory. See the ASV documentation linked above for more details on what the software can do.

Points for future discussion:

  • What tests should be included in the suite?
  • What will be the standard arguments for asv run, and how should we store these?
    • Documentation?
    • A small text file that could be referenced in the building of scripts?

@trexfeathers
Copy link
Contributor Author

Covers some of #3495

@bjlittle bjlittle self-assigned this Nov 13, 2019
@bjlittle
Copy link
Member

@trexfeathers Do we need to add the asv package to the requirements/test.txt to make it a dependency?

@bjlittle bjlittle self-requested a review November 13, 2019 06:45
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers This is awesome, so looking forward to getting asv up and running - it's an invaluable contribution to iris.

Just a couple of review actions to service, but otherwise looks good to me 👍

@bjlittle
Copy link
Member

@trexfeathers Perhaps not in this PR, but we should also provide documentation for the iris developer on how to use asv etc

@trexfeathers
Copy link
Contributor Author

@trexfeathers Do we need to add the asv package to the requirements/test.txt to make it a dependency?

@bjlittle nice catch. The existing automated tests would not break without this, but it's still clearer to have asv as a dependency, so I've added it 😊

@trexfeathers
Copy link
Contributor Author

@trexfeathers Perhaps not in this PR, but we should also provide documentation for the iris developer on how to use asv etc

@bjlittle 100% with you, once we have an agreed way of using ASV that we can document. I'm particularly interested in standardising the asv run arguments in some way.

@bjlittle
Copy link
Member

@bjlittle 100% with you, once we have an agreed way of using ASV that we can document. I'm particularly interested in standardising the asv run arguments in some way.

Nice. How do we capture this intent moving forwards? An issue? Elsewhere? Or have you got that covered? 😉

@trexfeathers
Copy link
Contributor Author

@bjlittle 100% with you, once we have an agreed way of using ASV that we can document. I'm particularly interested in standardising the asv run arguments in some way.

Nice. How do we capture this intent moving forwards? An issue? Elsewhere? Or have you got that covered? 😉

I'm not intending to map out next steps until I have finished experimenting with local routine testing schedules as this will inform further discussion.

@bjlittle
Copy link
Member

@trexfeathers asv cleared for take-off runway iris 🎉

@bjlittle bjlittle merged commit b2ce2a3 into SciTools:master Nov 13, 2019
@bjlittle bjlittle added the Feature: ASV AVD-1337 label Nov 22, 2019
@trexfeathers trexfeathers deleted the asv_setup branch February 17, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants