PI-3473 Rename "engine.provides"#3590
Merged
abooton merged 2 commits intoSciTools:launch_ancilsfrom Dec 20, 2019
Merged
Conversation
pp-mo
changed the title
pp-mo
force-pushed
the
rename_provides
branch
from
cc15af5 to
3bd0f82
Compare
Member
Author
Note: this makes sense due to already-mentioned dependence on #3556, which is on the feature branch |
pp-mo
force-pushed
the
rename_provides
branch
from
3bd0f82 to
2af3534
Compare
Member
Author
|
Thanks @stephenworsley |
stephenworsley
approved these changes
Dec 20, 2019
Contributor
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Looks good, this can be merged when Travis passes.
abooton
pushed a commit
to abooton/iris
that referenced
this pull request
Jun 5, 2020
stephenworsley
added a commit
to stephenworsley/iris
that referenced
this pull request
Aug 20, 2020
… launch_ancils * 'launch_ancils' of https://github.com/SciTools/iris: Resolve conflicts with requirements/test.txt to update the imagehash pin to imagehash>=4.0 (SciTools#3735) PI:3358 (WIP) Ensure flags load/save without units (SciTools#3613) PI-3473 Rename "engine.provides" (SciTools#3590) PI-3473: Whatsnews relating to ancillary load + save. (SciTools#3557) PI-3473: Netcdf loading ancillary variables (SciTools#3556) � Conflicts: � lib/iris/fileformats/netcdf.py � lib/iris/tests/unit/fileformats/netcdf/test__load_aux_factory.py � requirements/core.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During work on #3556, it became clear to me that the use of
engine.provideswithin the pyke rules, and in a few places withiniris.fileformats.netcdfis confusing : Because this term collides with the special reserved meaning of "provides" within Pyke rules, as seen in the repeated usage offacts_cf.provides(..)in most of our Pyke rules.In fact, although
engineis a Pyke object,engine.providesis just a monkey-patched additional property attached by our netcdf code, to keep track of cube component objects created during rules evaluation (coordinates, cell-measures and ancillaries).So, this PR just renames it to something less confusing.
This should produce no functional change.