Support loader-specific args in iris load functions.#3720
Closed
pp-mo wants to merge 1 commit intoSciTools:mainfrom
Closed
Support loader-specific args in iris load functions.#3720pp-mo wants to merge 1 commit intoSciTools:mainfrom
pp-mo wants to merge 1 commit intoSciTools:mainfrom
Conversation
Merged
Member
Author
|
I'm reviving this because I am again contemplating #3333 following some further experience with problem cases. Unfortunately we currently have a train wreck in the CI due to a problem with latest-version matplotlib docs. |
Member
Author
|
#4572 now proposes an alternative control mechanism. |
Member
Author
|
Not currently needed / no driver plus ... much of this (like chunking control) could be done with context managers instead ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been requested, to support #3647.
Previously considered for other cases, e.g. #3333 (but we didn't proceed with that).
Note: decided not to implement arbtrary additional (unnamed) args here, as the already optional positional args (constraints, callback) would make that rather messy.
We could still implement
**kwargsinstead of a specific keyword, if preferred? But I thought that might also lead to confusion..Note: the changes reach further than I had imagined (into iris.fileformats and iris.io), but I believe this still does not introduce any breaking changes. Nevertheless, I've marked it up for Iris 3.0