remove stock_mdi_arrays.npz#3913
Merged
trexfeathers merged 2 commits intoSciTools:masterfrom Dec 8, 2020
Merged
Conversation
rcomer
added
the
Peloton 🚴♂️
trexfeathers
approved these changes
Dec 8, 2020
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Hi @rcomer, thanks for doing the due diligence on this 💯, and sorry for leaving you hanging for so long.
I agree with your assessment. The only reference to stock_mdi_arrays in Iris goes through the usual test data handling that will allow it to pick up the file from iris_test_data as usual:
iris/lib/iris/tests/stock/__init__.py
Line 676 in dee8a55
Member
Author
|
Thanks @trexfeathers! I wasn't in any hurry, just saw an opportunity to close another old issue! Thanks also for sorting out my branch as I had forgotten it would need a rebase. |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Feb 9, 2021
* master: (23 commits) Added text to state the Python version used to build the docs. (SciTools#3989) add nox session conda list (SciTools#3990) Add abstract cube summary (SciTools#3987) automate docs discovery of iris and python versions (SciTools#3981) corrected syntax (SciTools#3980) core dev whatsnew entry (SciTools#3978) moved docs dir and updated references to it (SciTools#3975) Fix test_incompatible_dimensions test (SciTools#3977) remove explicit URLs for core dev names from latest.rst (SciTools#3973) document that iris.coords.Coord is an ABC (SciTools#3971) reorganise docs common links + add core devs (SciTools#3972) Docs whatsnew add dropdowns to the template (SciTools#3969) Docs whatsnew enumerated lists (SciTools#3970) Merge back v3p0p1 (SciTools#3966) Captilise installation heading - align SciTools#3958 content with SciTools#3940. (SciTools#3963) Merge back v3p0p0 (SciTools#3960) Extended the installation description (SciTools#3958) Put cube data on the x axis if plotting just a cube against a vertical or y coordinate (SciTools#3906) remove stock_mdi_arrays.npz (SciTools#3913) Gallery: update seasonal ensemble example (SciTools#3933) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #2455. Specifically #2455 (comment):
It looks like this file was accidentally left behind at #2212.
Marking this for @SciTools/peloton as I reckon it's an easy win.
I may have uncovered a snag in the new whatsnew writing procedures, in that you have to anticipate your PR number if you add it straight away! 😆
Consult Iris pull request check list