You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replaced beautifultable with minimalist home-brew solution for printing text entries in columns.
Still WIP
TODO : better code comments + proper testing
FUTURE : This should convert into a follow-on to #3952, when that is done. It will need resolving against changes in that.
IN PROGRESS : I'm working on replacing actual cube summaries with this, and fixing existing tests for that.
@bjlittle Is this PR active? ... Can it be closed?
This is just a heads-up + draft to show thinking.
It was against v3.0.x as we started there in anticipation of the merge back to master.
I have new code, re-targetted against master, but I am waiting for #3988 before making a PR, as we are still making changes there to the underlying implementation of the CubeSummary class, so requiring re-basing of the CubePrintout code. When #3988 is done, I will close this and replace it.
We agreed yesterday that we will put this CubePrintout code onto master, but keep it private (or maybe in iris.experimental).
Meanwhile, the switch to finally replace the existing Cube.summary() implementation with this will be done initially on the "mesh-data-model" feature branch instead -- just so that we can defer the additional work to fix any awkward test knockons, like its breaking Cube._repr_html_().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
New code for first eyes. Replaces #3962
Replaced beautifultable with minimalist home-brew solution for printing text entries in columns.
Still WIP
TODO : better code comments + proper testing
FUTURE : This should convert into a follow-on to #3952, when that is done. It will need resolving against changes in that.
IN PROGRESS : I'm working on replacing actual cube summaries with this, and fixing existing tests for that.
Consult Iris pull request check list