Widen cube printout for long ancil or cell-measure names.#4124
Merged
trexfeathers merged 2 commits intoSciTools:mainfrom Jun 25, 2021
Merged
Widen cube printout for long ancil or cell-measure names.#4124trexfeathers merged 2 commits intoSciTools:mainfrom
trexfeathers merged 2 commits intoSciTools:mainfrom
Conversation
trexfeathers
approved these changes
Jun 25, 2021
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Sorry for the delay @pp-mo. LGTM
Member
Author
|
Thanks @trexfeathers |
This was referenced Jul 7, 2021
Closed
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 21, 2021
* main: (43 commits) [pre-commit.ci] pre-commit autoupdate (SciTools#4244) Updated environment lockfiles (SciTools#4242) [pre-commit.ci] pre-commit autoupdate (SciTools#4239) Documented the --force option on conda env create (SciTools#4240) Updated environment lockfiles (SciTools#4237) pre-commit isort and black --check only for cirrus-ci (SciTools#4235) Only run docs-building sessions with Python 3.8. (SciTools#4210) consolidate cirrus-ci documentation tasks (SciTools#4219) Updated environment lockfiles (SciTools#4223) Replace pyke nopyke (SciTools#4198) drop cirrus-ci minimal tests (SciTools#4218) remove change management tech paper (SciTools#4217) [pre-commit.ci] pre-commit autoupdate (SciTools#4213) Updated environment lockfiles (SciTools#4212) Widen cube printout for long ancil or cell-measure names. (SciTools#4124) convert docs print statements (SciTools#4209) optimise pre-commit (SciTools#4208) drop black and flake8 dependencies (SciTools#4181) pre-commit blacked docs (SciTools#4205) pre-commit update (SciTools#4204) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Fixes #4123
NOTE: adding the test exposed another bug in cube printout : When widening, it stopped showing the cube units !
I have fixed that as well, but it did cause a knock-on in one other test (see separate commit with results-file change).
I would really rather have tidied up first, with #3998
-- after all, this bug has probably happened because of the unreasonable complexity of the Cube.summary code !
But this one is quite a simple fix, and if we do #3998 later it can check that it still passes this test.
And there is still a good deal of work needed to inject good levels of testing into #3998
Consult Iris pull request check list