Mesh Loading (AVD-1813)#4262
Conversation
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
Some changes suggested, but no show-stoppers. Feel free to mark things as 'resolved' in my absence.
I've only looked properly at the implementation code : I haven't time now to scan all the tests for correct coverage + someone else will have to take this on
But it's looking good to me !
|
This branch doesn't yet support performance testing, so that will be run locally for now. |
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
Basically all quite nice, but I raised a few questions.
So here's some things to think about, anyway.
Unfortunately I'm still not really quite done -- I need to think about the coverage of the main new tests a bit more.
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
Ok, that's my part#2
and I think that's now all
except that I'm still thinking about the duplication of the CFUGridMeshVariable creation I mentioned before : I'm still thinking about whether I think that is something different from the existing cases, or not. But that shouldn't take me much longer, and I'll let you know shortly..
|
It looks like we need to make Meshes hashable (should fix failing tests). Logical arguments against, exactly as for Cube, but I think it's forgiveable. #4290 will tell us if this fixes the remaining problems... |
Allow Meshes to be hashed.
|
Thanks @pp-mo! |
* main: (71 commits) Skip TestConstrainedLoad if data missing (SciTools#4319) Add 'Good First Issue' label to reasons an issue doesn't go stale (SciTools#4317) Gallery: simplify quiver example (SciTools#4120) Improve styling in a minor way in docs (SciTools#4314) bump version (SciTools#4310) Made clear we only test on Linux. (SciTools#4309) Updated environment lockfiles (SciTools#4308) Include Discussions in Getting Involved. (SciTools#4307) Fixed text to show as link. (SciTools#4305) [pre-commit.ci] pre-commit autoupdate (SciTools#4299) Updated environment lockfiles (SciTools#4298) cartopy feature download (SciTools#4304) Mesh Loading (AVD-1813) (SciTools#4262) reset whatsnew latest (SciTools#4288) Updated environment lockfiles (SciTools#4289) Update cube.py (SciTools#4287) Integrated whatsnew for v3.1 release (rc0) (SciTools#4285) Version changes and final whatsnew tweaks for 3v1rc0. (SciTools#4284) Missing whatsnew entries for 3.1 release. (SciTools#4283) Update CF standard name table to v77 (SciTools#4282) ...
* main: (94 commits) added support for make html-noapi and html-quick for the docs build (SciTools#4333) Refactor some netcdf save code (SciTools#4301) [pre-commit.ci] pre-commit autoupdate (SciTools#4329) Update to loading docs to cover absence of 'or' for constraints (SciTools#4321) update latest.rst.template (SciTools#4323) stable cartopy feature download (SciTools#4328) Skip TestConstrainedLoad if data missing (SciTools#4319) Add 'Good First Issue' label to reasons an issue doesn't go stale (SciTools#4317) Gallery: simplify quiver example (SciTools#4120) Improve styling in a minor way in docs (SciTools#4314) bump version (SciTools#4310) Made clear we only test on Linux. (SciTools#4309) Updated environment lockfiles (SciTools#4308) Include Discussions in Getting Involved. (SciTools#4307) Fixed text to show as link. (SciTools#4305) [pre-commit.ci] pre-commit autoupdate (SciTools#4299) Updated environment lockfiles (SciTools#4298) cartopy feature download (SciTools#4304) Mesh Loading (AVD-1813) (SciTools#4262) reset whatsnew latest (SciTools#4288) ...
2 participants
🚀 Pull Request
Description
Load
Meshes without associatedCubes.TODO:
[ ] Performance testsConsult Iris pull request check list