Conversation
e8bba98 to
90f3ad3
Compare
lib/iris/tests/integration/experimental/ugrid_conventions_examples/README.txt
Show resolved
Hide resolved
| @@ -0,0 +1,75 @@ | |||
| dimensions: | |||
| Mesh2_edge_N_faces = 2 ; | |||
There was a problem hiding this comment.
N.B. this use of separate dims for the last dim of different connectivity types is by design,
but it could seem wasteful.
we could change this, even create all "small" dimension values only once + re-use them
| def test_example_roundtrips(self): | ||
| # Check that save-and-loadback leaves Iris data unchanged, | ||
| # for data derived from each UGRID example CDL. | ||
| # Snapshot the result of saving the example cases. |
There was a problem hiding this comment.
| # Snapshot the result of saving the example cases. |
Copied in error
|
At the risk of some confusion, I'm going to update this with subsequent commits.
|
| vector_dim_coords = [ | ||
| coord for coord in dim_coords if id(coord) not in scalar_coord_ids | ||
| ] | ||
| if cube.mesh is None: |
There was a problem hiding this comment.
I've just done this for now, as it was irritating me + making debugging hard (not to easily see when there is a mesh or not).
This probably belongs in it's own PR.
c3c24ff to
cedcda4
Compare
|
Rebased, should now pass tests. |
| # metadata comparison | ||
| eq = self.metadata == other.metadata | ||
| if eq: | ||
| eq = self.shape == other.shape |
There was a problem hiding this comment.
This fixes it so that connectivities of different shapes can compare correctly (i.e. returns False).
Was failing with error, due to problems of array comparison.
ad10a63 to
551367e
Compare
🚀 Pull Request
Description
Beginnings of real save code.
Current status :
...tests/unit/fileformats/netcdf/test_Saver__ugrid.py)NOTE :
at present, the first commit is that shown in #4301
Until/unless that itself is merged, it may make more sense to view this relative to the #4301 code
Consult Iris pull request check list