Merged
Conversation
pp-mo
force-pushed
the
ugrid_save_mesh
branch
2 times, most recently
from
949119b to
0b49f71
Compare
pp-mo
force-pushed
the
ugrid_save_mesh
branch
from
0b49f71 to
59c93d5
Compare
pp-mo
commented
Sep 28, 2021
Member
Member
Author
Whoops yes, absolutely. |
pp-mo
commented
Sep 29, 2021
Member
Author
|
Thanks @bjlittle ! Now addressed above comments (I hope). |
bjlittle
reviewed
Sep 29, 2021
bjlittle
reviewed
Sep 29, 2021
bjlittle
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Mesh saving.
An addon to the general unstructured-cube saving (#4318).
This does further complicate things a bit, hopefully not too much.
Consult Iris pull request check list