g1_level1 handle surface level type #452
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -553,10 +553,15 @@ CellMethod("_ratio", cm.coord("time")) | |
|
|
||
| IF | ||
| grib.edition == 1 | ||
| grib.indicatorOfTypeOfLevel == 100 | ||
| THEN | ||
| CoordAndDims(DimCoord(points=grib.level, long_name="pressure", units="hPa")) | ||
|
|
||
|
|
||
| IF | ||
| grib.edition == 1 | ||
| grib.indicatorOfTypeOfLevel = 1 | ||
|
Member
There was a problem hiding this comment. This is the typo @bblay is talking about. I'm not sure whether this works or not (it used to), but I agree we should use the equality operator here. |
||
| THEN | ||
| CoordAndDims(DimCoord(points=0, long_name="height", units="m")) | ||
|
Member
There was a problem hiding this comment. While you're at it, would you mind removing one of the two spaces?
Member
There was a problem hiding this comment. Is is worth setting the standard_name to 'height', rather than the long name, given it is a valid one? Is it also worth adding an |
||
|
|
||
|
|
||
| ################### | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my subsequent work on a similar issue, I've found that this code has another misunderstanding ...
It seems that the gribapi defaults have changed so that default access to this parameter (as in "message.attribute") now returns a string instead of a number as previously. So instead of numbers 1 and 100, we now get 'sfc' and 'pl' (i.e. "surface" and "pressure level").
Also note, the alternative parameters levelType and indicatorOfTypeOfLevel aren't different (as you might expect), but behave exactly the same (and they both now return strings in this way).
So, I believe this whole section should now read :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Changing data types (and contents) of "computed keys", such as
levelType, has been problem for many years. However, I didn't expect "coded keys", such asindicatorOfTypeOfLevel, to suffer from this as they should reflect the grib spec, which states the data type. Because we've been using a computed key here for some time I can't be sure if this is a recent change or if it has always been decoded as a string (https://software.ecmwf.int/issues/browse/SUP-484).I suggest we remove this vulnerability. We can force
GribWrapperto give us the coded integer value for this key inGribWrapper.__getattr__, as we currently do fortypeOfFirstFixedSurface.