Conversation
|
@pp-mo - Thanks for putting this up so people can get early visibility. Please add a sentence to the PR description that tells people what new functionality it provides. |
Good point ! Done that now |
|
Addressed some shortcomings, and attempt to add ESMPy/ESMF function to Travis NOTE: the current build failure is an existing problem, unrelated to the code changes |
There was a problem hiding this comment.
It's not the derived auxiliary coordinates that are regridded, it's their reference surfaces. And perhaps "linear interpolation" should be "bilinear interpolation" to reduce ambiguity.
Handy hint: |
Thanks, will do this in future. |
Now removed: think we can now merge this (once "sufficiently fixed") Thinking behind this:
|
|
Do you plan on squashing this @pp-mo? |
|
Small changes for comments - thanks @rhattersley. Please re-examine. |
There was a problem hiding this comment.
Is it worth switching to the new api?
I assume this has already been discussed but I thought I'd ask.
There are currently two supported packages: ESMP and ESMPy. Both of these packages have the same general functionality. ESMP was a first prototype and ESMPy has a more Pythonic interface. After the ESMF_620 release (expected in May), the ESMP package will be deprecated and the ESMPy package will enter a beta phase.
There was a problem hiding this comment.
the from_coords bit is not quite true : )
This is just a first attempt.
It adds an experimental routine to perform conservative regridding (i.e. preserving area sums).
It uses the ESMPy interface to the ESMF codebase ( See notes at www.earthsystemmodeling.org/ ).
It should work once you have installed ESMPy. I have a site-specific script for that, if you need it.
-- or see how it is done in '.travis.yml'
More importantly, what it does not yet do ..
More testcases maybe needed :