Conversation
|
Helpful hint: To present a PR without the risk of accidental merge, pull it to your own master...You have got a master, haven't you? 😉 |
|
Thanks @bblay, but I trust the failing tests and 23 commits would prevent accidental merging 😉. |
lib/iris/experimental/regrid.py
Outdated
|
Out of scope really as it's not your code, but |
|
Great job @esc24. |
|
The code is set up to handle the x or y coord being scalar, as we'd expect from a cross-section. Please add tests for x and y cross sections (consider adding one for a single-column cube too). |
|
Please add a tests for non-contiguous x and y bounds. |
|
Please add a test for incompatible coords (i.e name, units or attribute, as detected in |
|
Extending the request for cross-section tests, please include attempts to regrid between a cross section and a horizontal grid. |
|
Please add tests for missing x and y coords. |
There was a problem hiding this comment.
This comment about a spherical effect seems wrong here, we just disabled spherical calculations.
The PR adds area weighted regridding to
iris.experimental.regrid.It is not the finished product:
I have put it up so @bblay can begin the review process.
Note the travis failures are due to an expectation that
is_contiguouswill be modified (#459), partial aux factory support and a dependency on numpy 1.7 to support a tuple as the axis argument.