Skip to content

Area weighted regridding#464

Merged
bblay merged 2 commits intoSciTools:masterfrom
esc24:area_weighted_regrid
May 3, 2013
Merged

Area weighted regridding#464
bblay merged 2 commits intoSciTools:masterfrom
esc24:area_weighted_regrid

Conversation

@esc24
Copy link
Member

@esc24 esc24 commented Apr 17, 2013

The PR adds area weighted regridding to iris.experimental.regrid.

It is not the finished product:

  1. More testing is needed,
  2. I need to handle aux factories so the surface altitude is regridded using area weighting.
  3. Removal of debug print statements.

I have put it up so @bblay can begin the review process.

Note the travis failures are due to an expectation that is_contiguous will be modified (#459), partial aux factory support and a dependency on numpy 1.7 to support a tuple as the axis argument.

@ghost ghost assigned bblay Apr 17, 2013
@bblay
Copy link
Contributor

bblay commented Apr 19, 2013

Helpful hint: To present a PR without the risk of accidental merge, pull it to your own master...You have got a master, haven't you? 😉

@esc24
Copy link
Member Author

esc24 commented Apr 19, 2013

Thanks @bblay, but I trust the failing tests and 23 commits would prevent accidental merging 😉.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rogue word "coordinate"?

@bblay
Copy link
Contributor

bblay commented Apr 29, 2013

Out of scope really as it's not your code, but _create_cube doesn't describe the conditions in which it can trigger a KeyError. An example would be really helpful in understanding this.

@bblay
Copy link
Contributor

bblay commented Apr 29, 2013

Great job @esc24.
I have reviewed the main code and will review the tests and play with it next.

@bblay
Copy link
Contributor

bblay commented Apr 29, 2013

The code is set up to handle the x or y coord being scalar, as we'd expect from a cross-section. Please add tests for x and y cross sections (consider adding one for a single-column cube too).

@bblay
Copy link
Contributor

bblay commented Apr 29, 2013

Please add a tests for non-contiguous x and y bounds.

@bblay
Copy link
Contributor

bblay commented Apr 29, 2013

Please add a test for incompatible coords (i.e name, units or attribute, as detected in Coord.is_compatible)

@bblay
Copy link
Contributor

bblay commented Apr 29, 2013

Extending the request for cross-section tests, please include attempts to regrid between a cross section and a horizontal grid.

@bblay
Copy link
Contributor

bblay commented Apr 29, 2013

Please add tests for missing x and y coords.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment about a spherical effect seems wrong here, we just disabled spherical calculations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants