Merged
Conversation
Member
There was a problem hiding this comment.
Looks like this has been truncated ... ?
Member
Author
|
Updated copyright year end and created issue #484 to cover future work 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily, this PR extends the capability of cube merge to correctly deal with string coordinates.
Previously, cube merge did not take into account the
dtypeof a coordinate, and as a result it was possible for cube merge to consider/nominate a string coordinate over other more appropriate numeric coordinates to describe a dimension.This PR allows cube merge to now favour numeric over string coordinates. It also takes the additional step to allow cube merge to favour
DimCoordscalar coordinates overAuxCoordscalar coordinates. This provides a simple mechanism that allows a user to easily hint to cube merge which scalar coordinate to consider when attempting to describe a dimension.This PR also resolves the situation when a
NotYetImplementedErrorexception was raised when the situation ofNo functional relationship between separable and inseparable candidate dimensionswas determined. Instead, the candidate coordinates participating within this group are all enumerated along an anonymous dimension.