Added a test for license checking of code files. Closes #454. by pelson · Pull Request #477 · SciTools/iris

pelson · 2013-04-25T16:42:11Z

No description provided.

pelson · 2013-04-25T17:02:56Z

Closes #454.

esc24 · 2013-04-26T07:47:37Z

lib/iris/tests/test_coding_standards.py

Vertical alignment?

pelson · 2013-04-26T08:21:03Z

Thanks @esc24. Done.

esc24 · 2013-04-26T08:22:00Z

lib/iris/tests/test_coding_standards.py

Could you put the directory name in the message?

pelson · 2013-04-26T09:54:23Z

Ok, thanks @esc24 - I think that is everything. I'll squash the commits when you're happy for me to do so.

esc24 · 2013-04-26T10:45:19Z

lib/iris/tests/test_coding_standards.py

I'm still getting an error: fatal: '/path/to/iris' is outside repository when running the code from outside the repository. I know it's a corner case, but it appears to be related to my iris directory being a symlink. If you remove the REPO_DIR from the list of args, problem solved. I think this is fine as you're now setting the cwd to be REPO_DIR.

Thanks @esc24 - there are some real subtitles here. I'll remove the REPO_DIR as you suggest.

pelson · 2013-04-26T14:02:46Z

Thanks @esc24 - rebased.

Added a test for license checking of code files. Closes #454.

rhattersley · 2013-04-30T10:43:39Z

lib/iris/tests/experimental/test_abf.py

I didn't believe it was 2010, but I also didn't check. It might have been 2012 even...

Ok, so git whatchanged says it was 2012...:

$> git whatchanged lib/iris/tests/experimental/test_abf.py

I'll submit a PR.

rhattersley · 2013-05-01T08:43:23Z

lib/iris/tests/experimental/regrid/__init__.py

This should just be 2013 (i.e. no 2012)

esc24 reviewed Apr 26, 2013
View reviewed changes

lib/iris/tests/test_coding_standards.py Outdated

Copy link

Member

esc24 Apr 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vertical alignment?

esc24 reviewed Apr 26, 2013
View reviewed changes

lib/iris/tests/test_coding_standards.py Outdated

Copy link

Member

esc24 Apr 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the directory name in the message?

esc24 reviewed Apr 26, 2013
View reviewed changes

Added a test for license checking of code files. Closes SciTools#454.

d242848

ghost assigned esc24 Apr 29, 2013

esc24 added a commit that referenced this pull request Apr 30, 2013

Merge pull request #477 from pelson/license_header_check

b221421

Added a test for license checking of code files. Closes #454.

esc24 merged commit b221421 into SciTools:master Apr 30, 2013

rhattersley reviewed Apr 30, 2013
View reviewed changes

rhattersley mentioned this pull request May 1, 2013

Fixed copyright date on one of the tests. #483

Merged

rhattersley reviewed May 1, 2013
View reviewed changes

esc24 mentioned this pull request May 1, 2013

Fix to copyright licence check logic #487

Merged

Conversation

pelson commented Apr 25, 2013

Uh oh!

pelson commented Apr 25, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pelson commented Apr 26, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pelson commented Apr 26, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pelson commented Apr 26, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants