fix aggregated_by for derived coords#4947
Merged
bjlittle merged 3 commits intoSciTools:mainfrom Nov 9, 2022
Merged
Conversation
stephenworsley
force-pushed
the
aggregate_derived_coords
branch
from
5fe77a5 to
1c181c3
Compare
stephenworsley
force-pushed
the
aggregate_derived_coords
branch
from
7f3ff2e to
55dab86
Compare
bjlittle
approved these changes
Nov 9, 2022
Member
bjlittle
left a comment
bjlittle
left a comment
There was a problem hiding this comment.
@stephenworsley Looks good to me.
Awesome, thanks! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Addresses the remaining comments for #3637.
Does this by having all derived coordinates now derive from their equivalent coordinates in the aggregated cube.
Consult Iris pull request check list