Speed up Cube.subset/Coord.intersect#4955
Merged
lbdreyer merged 2 commits intoSciTools:mainfrom Oct 11, 2022
Merged
Conversation
bouweandela
commented
Sep 9, 2022
c80b0fe to
02bd3da
Compare
8 tasks
548f979 to
00048fb
Compare
00048fb to
c1bc2d6
Compare
lbdreyer
requested changes
Oct 10, 2022
Member
lbdreyer
left a comment
There was a problem hiding this comment.
This is looking great, thanks @bouweandela ! Do you mind adding a whatsnew entry to cover this change?
Member
Author
|
Thanks for the review @lbdreyer ! I added the entry. |
lbdreyer
approved these changes
Oct 11, 2022
Member
lbdreyer
left a comment
There was a problem hiding this comment.
Perfect! Thanks @bouweandela !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This speeds up
Cube.subset/Coord.intersectby using adictlookup instead oflist.indexto find the indices of the coordinate that should be used for subsetting the cube.Here is some benchmark code:
The current
mainbranch result is:and the result of running that code with this branch is:
Consult Iris pull request check list