Conversation
pp-mo
left a comment
There was a problem hiding this comment.
This looks cool, though I did have a bit of a wobble about requiring Matplotlib >= 3.5.
That is now ~10months old. But I guess this is anyway not an actual Iris dependency, its only for CI,
so I think that is fine.
|
Nice work @trexfeathers . We'll see how it goes tomorrow morning ! |
This is genuine. When this is released (December), Matplotlib 3.4 will not be usable with Iris |
|
Ok, hadn't really thought of it that way. |
|
This raises interesting questions about proactively responding to deprecation warnings. We typically don't spot them until the deprecation fully happens, and therefore don't experience the problem of very 'young' pins. In this case I spotted the warning while investigating and chose to action it, introducing this different problem! |
🚀 Pull Request
Description
These changes address a Matplotlib deprecation warning, and should get the overnight benchmarks working again.
Consult Iris pull request check list