Reference the RTD version switcher in the docs latest warning#5055
Merged
tkknight merged 1 commit intoSciTools:mainfrom Nov 10, 2022
Merged
Reference the RTD version switcher in the docs latest warning#5055tkknight merged 1 commit intoSciTools:mainfrom
tkknight merged 1 commit intoSciTools:mainfrom
Conversation
tkknight
approved these changes
Nov 10, 2022
Contributor
|
Looks good. There is a chance that a user is viewing a docs page that is in latest and added in latest, so if they view a stable version via the version switch flyout menu, the browser will try to load a page that does not exist for that earlier version. Read The docs will show a page like this:
I think this will not be a frequent occurrence and the error message is informative so lets get this merged. |
Contributor
Author
|
Thanks @tkknight! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Ref: #5045 and #4396 (comment)
Consult Iris pull request check list