Merged
Conversation
Member
Author
|
Happy to forward relevant email thread to whoever reviews this. |
trexfeathers
approved these changes
Nov 11, 2022
Member
Author
|
Thanks @trexfeathers! |
Contributor
|
Thanks for sourcing some wisdom @rcomer, as software developers (not scientists) we rely on this sort of help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
STASH diagnostic 30311 is listed in the UM STASHmaster metadata file as "RESIDUAL MN MERID. CIRC. WSTARBAR". I have checked with Steve Hardiman (who originally implemented these diagnostics in the UM) and Martin Andrews (who has used these diagnostics a lot more than I have) and they agree that this should map to "upward" rather than "northward" in Iris.
Consult Iris pull request check list