Merged
Conversation
Member
Author
|
If we're happy to go with this temporary fix then I'll make an issue to remind us to remove the temporary pin introduced by this pr in the |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jan 4, 2023
* upstream/main: pip pin for sphinx<5 (SciTools#5122)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jan 5, 2023
* upstream/main: (167 commits) pip pin for sphinx<5 (SciTools#5122) [pre-commit.ci] pre-commit autoupdate (SciTools#5120) Bump actions/stale from 6 to 7 (SciTools#5117) [pre-commit.ci] pre-commit autoupdate (SciTools#5114) Correct heading for v3.4 release highlights. (SciTools#5110) Announce @ESadek-MO as a core Iris developer. (SciTools#5111) Remove test timings (SciTools#5101) Switch order of options and parameter in `ncgen` command (SciTools#5105) [pre-commit.ci] pre-commit autoupdate (SciTools#5107) Updated environment lockfiles (SciTools#5104) DOC: improve gallery test instructions (SciTools#5100) Updated environment lockfiles (SciTools#5092) Update What's New for 3.4 release. (SciTools#5088) [pre-commit.ci] pre-commit autoupdate (SciTools#5086) Updated environment lockfiles (SciTools#5085) Updated environment lockfiles (SciTools#5080) Restore latest What's New files. Documentation updates for `v3.4.0rc0` release. (SciTools#5078) What's New fixes. (SciTools#5077) More accurate netcdf4 pin `<1.6.1`. (SciTools#5075) ...
trexfeathers
pushed a commit
to trexfeathers/iris
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR temporarily resolves the existing documentation build failure on RTD i.e., see here
There are a couple of factors in play here:
sphinx-panelspackage is no longer maintained (sphinx-panels package no longer maintained #5121) and is pinning back thesphinxpackage from >=v6.0.0 to v4.5.0 onconda-forgepydata-sphinx-themeis pinned to v0.8.1 (latest version available is >=v0.12.0), and this is causing the additionalpip installstep on RTD to pull thesphinxpackage way down to v3.5.3 which is incompatible and, I suspect, causing the following traceback:We can circumvent this dependency carnage (no thanks to
pip) by introducing the temporary maximum pinsphinx<5within thesetup.cfg, which prevent thepipdependency resolver "stuffing up" ™️, and maintaining the compatible dependencies resolved and installed byconda.However, as a follow-up, I strongly recommend that we address:
sphinxpydata-sphinx-themeback at v0.8.1The documentation built by this PR can be viewed here and the RTD raw build output is available here.
Consult Iris pull request check list