Closed
Conversation
Contributor
Author
|
Not sure about introducing a default ellipsoid. We might not be saving the same thing as we loaded... |
Contributor
Author
|
One outstanding doctest failure: Looks like a str() vs repr() but not sure how that could be happening yet. |
Merged
Member
There was a problem hiding this comment.
This is really a comment about the GeogCS class/constructor. Can we ditch the units keyword - CF mandates the radius and major/minor axes are expressed in metres. And the GeogCS constructor should probably cast to float to be on the safe side. That would give:
lat_lon_coord_system = icoord_systems.GeogCS(6371229)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45