Skip to content

CF coord systems#52

Closed
bblay wants to merge 4 commits intoSciTools:masterfrom
bblay:cfcs
Closed

CF coord systems#52
bblay wants to merge 4 commits intoSciTools:masterfrom
bblay:cfcs

Conversation

@bblay
Copy link
Contributor

@bblay bblay commented Aug 21, 2012

Fixes #45

@bblay
Copy link
Contributor Author

bblay commented Aug 21, 2012

Not sure about introducing a default ellipsoid. We might not be saving the same thing as we loaded...

@bblay
Copy link
Contributor Author

bblay commented Aug 21, 2012

One outstanding doctest failure:
From surface_altitude: Cell(point=399.625, bound=(-14.0, 813.25)) m
to surface_altitude: Cell(point=399.625, bound=(-14.000001, 813.25)) m
under investigation.

Looks like a str() vs repr() but not sure how that could be happening yet.

@bblay bblay mentioned this pull request Aug 22, 2012
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really a comment about the GeogCS class/constructor. Can we ditch the units keyword - CF mandates the radius and major/minor axes are expressed in metres. And the GeogCS constructor should probably cast to float to be on the safe side. That would give:

lat_lon_coord_system = icoord_systems.GeogCS(6371229)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert coord-systems to CF

3 participants