Benchmark improvements, including passing exceptions upwards#5289
Closed
trexfeathers wants to merge 34 commits intoSciTools:mainfrom
Closed
Benchmark improvements, including passing exceptions upwards#5289trexfeathers wants to merge 34 commits intoSciTools:mainfrom
trexfeathers wants to merge 34 commits intoSciTools:mainfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
This benchmark run was requested for the penultimate commit (before the What's New entry).
Clearer exceptions/errors
subprocess.run, causing the workflow to fail.CI usability improvements
asv continuous, which uses an exit code of1where performance regressions are found - so we're not relying on developers to manually read the GitHub workflow.Fixes
(which now cause a workflow failure thanks to ab32be1 & b793971).
asv_delegated_conda.pyplugin is the only reason we need specifiedconda_channels(Performance Shift(s):bbb53585#5280 (comment)), I decided it was more appropriate / less misleading to hard-code the Conda channel into the plugin script itself.Consult Iris pull request check list