Iris Docs: Dark theme ready#5299
Merged
trexfeathers merged 8 commits intoSciTools:mainfrom May 24, 2023
Merged
Conversation
* upstream/main: update cf-standard-name-table (SciTools#5297) fix license badge (SciTools#5296)
Contributor
Author
|
Will resolve #4795 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5299 +/- ##
=======================================
Coverage 89.35% 89.35%
=======================================
Files 89 89
Lines 22417 22417
Branches 5382 5382
=======================================
Hits 20030 20030
Misses 1639 1639
Partials 748 748 ☔ View full report in Codecov by Sentry. |
* upstream/main: update release_do_nothing script (SciTools#5311) Restore latest Whats New files. Updated environment lockfiles (SciTools#5308) release_do_nothing script updates from v3.6.0rc0 (SciTools#5306) Whats new updates for v3.6.0rc0 (SciTools#5300) Bump scitools/workflows from 2023.04.3 to 2023.05.0 (SciTools#5303)
* upstream/main: Updated environment lockfiles (SciTools#5332) Support netcdf variable emulation (SciTools#5212) Support netCDF load+save on dataset-like objects as well as filepaths. (SciTools#5214) minor refinement to release do-nothing script (SciTools#5326) update bibtex citation for v3.6.0 release (SciTools#5324) Whats new updates for v3.6.0 (SciTools#5323) Added whatsnew notes on netcdf delayed saving and Distributed support. (SciTools#5322) Updated environment lockfiles (SciTools#5320) Bugfix 4566 (SciTools#4569) Simpler/faster data aggregation code in `aggregated_by` (SciTools#4970)
Contributor
Author
|
Ready for review. |
trexfeathers
requested changes
May 23, 2023
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @tkknight. At least one fix to an image is needed, plus a few other comments.
trexfeathers
approved these changes
May 24, 2023
Contributor
|
Great, thanks @tkknight! Let's save some monitor energy and some retinas 💻👁 ... |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Nov 9, 2023
* upstream/main: Updated environment lockfiles (SciTools#5334) Iris Docs: Dark theme ready (SciTools#5299) Updated environment lockfiles (SciTools#5332) Support netcdf variable emulation (SciTools#5212) Support netCDF load+save on dataset-like objects as well as filepaths. (SciTools#5214) minor refinement to release do-nothing script (SciTools#5326) update bibtex citation for v3.6.0 release (SciTools#5324) Whats new updates for v3.6.0 (SciTools#5323) Added whatsnew notes on netcdf delayed saving and Distributed support. (SciTools#5322) Updated environment lockfiles (SciTools#5320) Bugfix 4566 (SciTools#4569) Simpler/faster data aggregation code in `aggregated_by` (SciTools#4970) update release_do_nothing script (SciTools#5311) Restore latest Whats New files. Updated environment lockfiles (SciTools#5308) release_do_nothing script updates from v3.6.0rc0 (SciTools#5306) Whats new updates for v3.6.0rc0 (SciTools#5300) Bump scitools/workflows from 2023.04.3 to 2023.05.0 (SciTools#5303)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Updates the Iris docs to be dark theme ready. This is a feature that the pydata-sphinx-theme supports.
PR build of the docs: https://scitools-iris--5299.org.readthedocs.build/en/5299/index.html
Changes include
svgimages have an increased border to so when there is a dark background it looks betterdark-lightclass where the figure/image is transparent, otherwise the theme will add a white background to the transparent image when using dark more. Sometimes this is ok though so the class has not been used everywhere.Minor issue outstanding
The Iris Voted Issues table looks ok apart from the pulldown and text entry that uses black text on the almost black background, making it very hard to read. This is not a major issue and unless there are objections should not stop this PR.
I expect this issue will resolve itself when
pydata-sphinx-themeis updated (and we unpin it) or when thedatatablescss is updated.Consult Iris pull request check list