Make roundtrip checking more precise + improve some tests accordingly.#5402
Make roundtrip checking more precise + improve some tests accordingly.#5402pp-mo wants to merge 2 commits intoSciTools:FEATURE_split_attrsfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_split_attrs #5402 +/- ##
=======================================================
+ Coverage 89.25% 89.41% +0.16%
=======================================================
Files 88 89 +1
Lines 22197 22500 +303
Branches 4858 5396 +538
=======================================================
+ Hits 19811 20119 +308
+ Misses 1641 1636 -5
Partials 745 745
☔ View full report in Codecov by Sentry. |
bceddd0 to
249bdb6
Compare
for more information, see https://pre-commit.ci
|
Closing pending a re-submission. I'm not happy with the apparently spurious commit from pre-commit-ci aiming to fix what is already fixed elsewhere (i.e. "later") on the feature-branch. Following discussion with @trexfeathers , I think we can simply logically accept that, from results in #5403, these proposed changes to the "status-quo" tests are valid. |
This provides an important tweak to the split-attrs feature branch, which really needs to be shown working with the main-branch code prior to the adoption of split attributes in cube content and loading (as already merged)