Skip to content

Stash std name#543

Closed
marqh wants to merge 3 commits intoSciTools:masterfrom
marqh:stashStdName
Closed

Stash std name#543
marqh wants to merge 3 commits intoSciTools:masterfrom
marqh:stashStdName

Conversation

@marqh
Copy link
Member

@marqh marqh commented Jun 5, 2013

Providing an updated STASH and standard_name translation resource, based on metarelate

@ajdawson
Copy link
Member

ajdawson commented Jun 5, 2013

The .travis.yml file explicitly calls python setup.py std_names, which you have removed, hence the tests cannot run. Please update .travis.yml.

@marqh
Copy link
Member Author

marqh commented Jun 5, 2013

The .travis.yml file explicitly calls python setup.py std_names, which you have removed, hence the tests cannot run. Please update .travis.yml.

cheers aj, I've updated this and fixed a mistake in the .gitignore which was masking a new file

i've still got one test failure (iris.tests.test_plot.TestPlotDimAndAuxCoordsKwarg) but i'm pretty sure I haven't been near this and it may be a matplotlib issue, rather than with this change, so I haven't investigated further

@ajdawson
Copy link
Member

ajdawson commented Jun 5, 2013

i've still got one test failure (iris.tests.test_plot.TestPlotDimAndAuxCoordsKwarg)

The only failures on Travis are license failures.

Only tools/translator/__init__.py is missing a header, contrary to what the test system says. I know this file is blank but perhaps it could do with being more like lib/iris/experimental/__init__.py with some description in there? I'm not sure.

The dates in the headers you have put in the other tools/translate/*.py files are incorrect though. They should just be 2013 I think since these files are new.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these above all really have the same field code? (501)

@cpelley
Copy link

cpelley commented Jun 7, 2013

^github bug, I'm refering to line 560-

@rhattersley
Copy link
Member

A note of caution - as with #542 (which looks to be a subset of this PR) there's an open question (with discussion already underway on #542 and the iris-dev discussion group) about how Iris and @metarelate will interact.

@rhattersley
Copy link
Member

Closed until re-worked to fit the new plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants