Merge the benchmark fixes and enhancements to main#5437
Merged
Conversation
* More sensible print and run functions. * Avoid permanent modifications in _subprocess_runner.
* On demand benchmarking. * Correct gh query. * Correct assignee spacing. * What's new entry.
* Don't check out head_ref - benchmark the GH simulated merge commit instead. * What's New entry.
* Include a warning step for overnight benchmarking. * Fix for failure warning script. * Better formatting of warning issue title. * What's new entry.
* Use shlex.split() for bm_runner commands. * Minor documentation clarifications.
* Set benchmark runs to error if the subprocess errors. * Still compare results even from a broken run. * Still upload reports if overnight run fails. * What's New entry.
* What's new entry. * What's New entry. * Hard-code conda channel into asv_delegated_conda.py . * Fix some rebase confusion in the What's New.
* Inflate benchmark data to ensure laziness. * What's New entry.
trexfeathers
added
Type: Performance
Type: Testing
Type: Merge Back
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5437 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 89 89
Lines 22443 22443
Branches 5381 5381
=======================================
Hits 20058 20058
Misses 1639 1639
Partials 746 746 ☔ View full report in Codecov by Sentry. |
* What's new entry. * Correct user name @ESadek-MO. * Missing colon.
ESadek-MO
approved these changes
Aug 21, 2023
Contributor
ESadek-MO
left a comment
ESadek-MO
left a comment
There was a problem hiding this comment.
Thanks @trexfeathers! Cool to see this go in!
Contributor
Author
|
Many thanks @ESadek-MO 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Draft for now, as needs an extra What's New entry
Consult Iris pull request check list