Merge chunk control code into latest iris#5565
Merged
trexfeathers merged 17 commits intoSciTools:FEATURE_chunk_controlfrom Nov 13, 2023
Merged
Merge chunk control code into latest iris#5565trexfeathers merged 17 commits intoSciTools:FEATURE_chunk_controlfrom
trexfeathers merged 17 commits intoSciTools:FEATURE_chunk_controlfrom
Conversation
trexfeathers
reviewed
Nov 7, 2023
for more information, see https://pre-commit.ci
…nstead of if var: )
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_chunk_control #5565 +/- ##
=========================================================
- Coverage 89.44% 89.43% -0.01%
=========================================================
Files 89 89
Lines 22583 22650 +67
Branches 5386 5406 +20
=========================================================
+ Hits 20199 20257 +58
- Misses 1638 1643 +5
- Partials 746 750 +4
☔ View full report in Codecov by Sentry. |
…o chunk_control_unstale
Contributor
Author
|
Chose to use I could find no reference to |
This was referenced Nov 10, 2023
Merged
trexfeathers
requested changes
Nov 10, 2023
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
This code holds together very nicely 👍
I know my notes relate to documentation and testing, which will be fully addressed later, but I'd rather not introduce problems when they have already been spotted.
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
trexfeathers
approved these changes
Nov 13, 2023
ESadek-MO
added a commit
that referenced
this pull request
Nov 23, 2023
* Merge chunk control code into latest iris (#5565) * Dask chunking control for netcdf loading. * renamed loader * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix indentation error, perhaps also docstring error * fixed result error in loader, and set tests to treat as big files * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * trial and error, solve non iterable tuple 1.0 * trial and error, solve non iterable tuple 2.0 (used if var is none: instead of if var: ) * commented out docstring * fixed mock 'no name' failure * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed precommit issues * corrected docstrings as per review comments * Removed unnecessary line Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> --------- Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Chunk control modes (#5575) * added modes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added as_dask mode * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * cleaned up enum and as_dask, as per review comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * corrected to in final place * unindented lazy_param assignment one indent --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Corrected required type of dimension_chunksizes. (#5581) * Chunk Control Tests (#5583) * converted tests to pytest, added neg_one, and incomplete from_file and as_dask tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added from_file test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added mocking tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * trial and error with mocks and patches, may or may not work * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * converted Mock to patch in as_dask test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * review comment changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * pre commit fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * review comments, and added test in test__get_cf_var_data() * added in another test * added tests and fixed review comments * added AuxCoord test --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Chunk control minor fixes (#5593) * Disallow chunks=None in optimum_chunksize. * Clearer docstrings. * Corrected docstring. * Chunk Control documentation (#5597) * init PR, skeleton TP * whoops, missed the TP. * fixed doctests in rst file * correct triple chevron to elipses * updated set doctest to better show functionality * removed in-progress doctest code * Review comments, part 1 * Review comments, part 2 * changed numpy docs dict * wait, this way is better * fixed linkcheck failures (maybe) * fixed :meth: * fixed a couple doc bits * hopefully fixed doctests * newest review comments * fixed rendering, and wording in docstring * fixed docstring numpyness * What's New Entry (#5601) * written whatsnew entry * added ref * moved label to before title --------- Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com> Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Addresses step one of #5399.
Takes code from #4572 and solves conflicts with latest changes in Iris.