Fix pp save of realization coordinate#5568
Merged
trexfeathers merged 4 commits intoSciTools:mainfrom Nov 30, 2023
Merged
Conversation
trexfeathers
requested changes
Nov 30, 2023
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @rcomer! Some comments for you
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5568 +/- ##
==========================================
+ Coverage 89.44% 89.68% +0.24%
==========================================
Files 89 90 +1
Lines 22583 22818 +235
Branches 5386 5446 +60
==========================================
+ Hits 20199 20465 +266
+ Misses 1638 1619 -19
+ Partials 746 734 -12 ☔ View full report in Codecov by Sentry. |
trexfeathers
approved these changes
Nov 30, 2023
Member
Author
|
Thanks @trexfeathers! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 4, 2023
* 'numpydocs1' of github.com:tkknight/iris: Feedstock rc branch management in do-nothing script (SciTools#5515) Relocated the Technical Papers documentation to Further Topics. (SciTools#5602) Fix pp save of realization coordinate (SciTools#5568) Bump actions/checkout from 3 to 4 (SciTools#5460) Bump actions/github-script from 6 to 7 (SciTools#5580) Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607) CI: specify matplotlib-base (SciTools#5606)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 6, 2023
* main: DOCS: Numpydocs1 (SciTools#5578) add links to scitools-classroom repo. (SciTools#5609) Feedstock rc branch management in do-nothing script (SciTools#5515) Relocated the Technical Papers documentation to Further Topics. (SciTools#5602) Fix pp save of realization coordinate (SciTools#5568) Bump actions/checkout from 3 to 4 (SciTools#5460) Bump actions/github-script from 6 to 7 (SciTools#5580) Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607) CI: specify matplotlib-base (SciTools#5606) Mergeback of `FEATURE_chunk_control` branch (SciTools#5588) [CI Bot] environment lockfiles auto-update (SciTools#5547) Mergeback of "Feature _split_attrs" branch (SciTools#5152) add whatsnew (SciTools#5596) Refactor area weighted regridding, improve performance (SciTools#5543) Allowing exemption to axis guessing on coords (SciTools#5551)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Fixes #4747 by adding some handling for the "realization" coordinate in
pp_save_rules.py.I followed the pattern of
_general_time_rulesin this module, and found the relevant field attribute by looking at the load code:iris/lib/iris/fileformats/pp_load_rules.py
Lines 947 to 950 in e0850eb
Also updated some docstrings and comments. There seem to have been some copypasta errors going on.
Consult Iris pull request check list