Remove test numbering, as an experiment.#5584
Closed
pp-mo wants to merge 1 commit intoSciTools:FEATURE_split_attrsfrom
Closed
Remove test numbering, as an experiment.#5584pp-mo wants to merge 1 commit intoSciTools:FEATURE_split_attrsfrom
pp-mo wants to merge 1 commit intoSciTools:FEATURE_split_attrsfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_split_attrs #5584 +/- ##
=======================================================
+ Coverage 89.25% 89.45% +0.20%
=======================================================
Files 88 90 +2
Lines 22197 22603 +406
Branches 4858 5437 +579
=======================================================
+ Hits 19811 20220 +409
+ Misses 1641 1638 -3
Partials 745 745 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This is just to check whether the problems discussed at #5037 are still a reality -- i.e. whether the "test numbering" strategy is still needed.
Even if it is no longer required, I don't actually propose that we should remove the test numbers,
but at least in that case we could happily close #5307 !