Fix test to ignore extra warnings from later versions of distributed.#5600
Merged
trexfeathers merged 1 commit intoSciTools:auto-update-lockfilesfrom Nov 22, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## auto-update-lockfiles #5600 +/- ##
========================================================
Coverage ? 89.45%
========================================================
Files ? 89
Lines ? 22603
Branches ? 5389
========================================================
Hits ? 20219
Misses ? 1638
Partials ? 746 ☔ View full report in Codecov by Sentry. |
trexfeathers
approved these changes
Nov 22, 2023
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks for your diligence, @pp-mo!
trexfeathers
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Updated environment lockfiles * Fix test to ignore extra warnings from later versions of distributed. (#5600) --------- Co-authored-by: Lockfile bot <noreply@github.com> Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #5547 problem
It seems that, when dask/distributed version 2023.9.3 --> 2023.11.0, some of our testcases trigger an additional warning about transferring large data to workers (only when using distributed).
I've confirmed that this isn't a new inefficiency : The test takes around 5 seconds via distributed, compared to 1 sec with a threaded or synchronous scheduler, and that performance hit is basically the same both before + after the version change.
So I guess it is just a new warning.
The tests that fail are testing the exact "data fill" warnings issued when saving to netcdf.
This PR gets the offending tests to explicitly ignore any warnings which look like that new message.