!EX! Relocate Technical Papers, with some changes to structure#5604
!EX! Relocate Technical Papers, with some changes to structure#5604ESadek-MO wants to merge 5 commits intoSciTools:mainfrom
Conversation
ESadek-MO
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5604 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 90 90
Lines 22815 22815
Branches 5445 5445
=======================================
Hits 20462 20462
Misses 1619 1619
Partials 734 734 ☔ View full report in Codecov by Sentry. |
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
I quite like this, but the issue with the extra top-bar item is a nuisance.
Maybe can fix as I suggested ??
Since this includes all of #5602 commits, I should think you can close that + declare this "good to go" instead. Unless you have other reservations + prefer the original.
| :func:`iris.analysis.calculus.differentiate`. | ||
|
|
||
| * A new :doc:`"Technical Papers" </techpapers/index>` section has been added to | ||
| * A new Technical Papers section has been added to |
There was a problem hiding this comment.
This could now be pointed a the new combined "further topics" page ?
I thought that was part of the reason for the new page !
There was a problem hiding this comment.
This is the 1.7 what's new; whereas all I had done was move where the Tech Papers section was, now I've removed it altogether. To change the path to further topics seems non-representative.
The file I've linked to because the file hasn't changed.
| Iris API <generated/api/iris> | ||
|
|
||
|
|
||
| .. toctree:: |
There was a problem hiding this comment.
I guess it is this which adds the unwanted extra top section.
Since this part appears at the end of the User Guide overview page, do we actually need this here ??
Disclaimer : I don't really understand this stuff.
( But at least I know it )
There was a problem hiding this comment.
It no longer does appear at the end of the User Guide overview, see the docs built from this PR.
By making it it's own section, I've removed it from the user guide toctree. This also removes it in the overview. Currently the only way to access this is through the navbar.
|
This was decided to be too far, so reverting to #5602 |
2 participants
🚀 Pull Request
An extension to #5602. This juggles structure around a bit more, takes it a bit further.
Consult Iris pull request check list